Revert "Improve typesubtract for tuples (#35600)" #37562
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit cf0c3e0.
|
The before (green) / after (blue) times here are pretty cool to see: The #37714 PR will make them a bit worse than the blue again, but not much (not like the green line). |
vtjnash
added a commit
that referenced
this pull request
Sep 24, 2020
KristofferC
pushed a commit
that referenced
this pull request
Oct 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #37448, reopens #35566
Uses of
switchtupleunionneed to be guarded in cost (e.g. withcountunionsplit), while there's currently no practical way to limit this. The inference algorithm assumes that the canonical form is that oftuplemerge, and dislikes when we form the switched version implicitly, as it has a higher lattice cost, so it's expected to only appear explicitly.